Skip to content

Remove c_enum_constant_type #7153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

This was put in place to succeed enum_constant_type (which was then deprecated), but neither of which are used for the C front-end has it's own (much more elaborate) way of doing enum_constant_type.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This was put in place to succeed enum_constant_type (which was then
deprecated), but neither of which are used for the C front-end has it's
own (much more elaborate) way of doing enum_constant_type.
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 77.88% // Head: 77.88% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8fe28ff) compared to base (ee0a06d).
Patch coverage: 90.54% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7153   +/-   ##
========================================
  Coverage    77.88%   77.88%           
========================================
  Files         1576     1576           
  Lines       181867   181863    -4     
========================================
  Hits        141645   141645           
+ Misses       40222    40218    -4     
Impacted Files Coverage Δ
src/ansi-c/expr2c.cpp 67.13% <ø> (ø)
src/goto-programs/restrict_function_pointers.h 100.00% <ø> (ø)
src/goto-programs/validate_goto_model.h 100.00% <ø> (ø)
src/util/c_types.cpp 91.16% <ø> (+1.97%) ⬆️
src/util/c_types.h 100.00% <ø> (ø)
src/util/format_expr.cpp 86.89% <0.00%> (ø)
src/util/simplify_expr_class.h 90.47% <ø> (ø)
unit/goto-programs/goto_program_validate.cpp 100.00% <ø> (ø)
src/goto-programs/restrict_function_pointers.cpp 82.15% <50.00%> (ø)
src/ansi-c/c_typecheck_expr.cpp 74.19% <72.72%> (ø)
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig self-assigned this Sep 28, 2022
@tautschnig tautschnig removed their assignment Oct 10, 2022
@kroening kroening merged commit dcb99a2 into diffblue:develop Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants