Skip to content

Mark memory hungry tests as THOROUGH #7134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

remi-delmas-3000
Copy link
Collaborator

These tests seem to require more memory than may be available on some GitHub runners.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

These tests seem to require more memory than
may be available on some GitHub runners.
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #7134 (309900f) into develop (9a14d1a) will not change coverage.
The diff coverage is 23.07%.

@@           Coverage Diff            @@
##           develop    #7134   +/-   ##
========================================
  Coverage    77.86%   77.86%           
========================================
  Files         1576     1576           
  Lines       181808   181808           
========================================
  Hits        141573   141573           
  Misses       40235    40235           
Impacted Files Coverage Δ
src/ansi-c/c_typecheck_expr.cpp 74.17% <0.00%> (ø)
src/ansi-c/goto_check_c.cpp 91.65% <0.00%> (ø)
src/util/pointer_expr.h 80.83% <0.00%> (ø)
src/solvers/flattening/boolbv_mod.cpp 93.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@kroening kroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right thing to do to unblock us in the short term.

I the long term, I do see a trend that the jbmc tests are gradually degrading owing to lack of maintenance.

@thomasspriggs
Copy link
Contributor

I think the problem shown here is actually related to infinite recursion causing an out of memory error for one particular platform, rather than due to inadequate memory availability. See #7148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants