Refactor/move abstract interpreter functionality into goto analyzer 1 #7120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 11, 2022 12:26
It is already supported, tested and documented so this is straight-forward. The biggest change is migrating and updating tests.
There is not much to do as this is already supported, tested and documented in goto-analyzer and there are no tests for this in goto-instrument.
The functionality is already present and tested so there is not much to do.
martin-cs
requested review from
chris-ryder and
peterschrammel
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #7120 +/- ##
===========================================
- Coverage 77.92% 77.87% -0.05%
===========================================
Files 1576 1576
Lines 181645 181643 -2
===========================================
- Hits 141541 141458 -83
- Misses 40104 40185 +81
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tautschnig
approved these changes
Sep 17, 2022
tautschnig
assigned peterschrammel, martin-cs and chris-ryder and unassigned tautschnig
peterschrammel
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first part of moving functionality that is basically "run the abstract interpreter and then ..." from
goto-instrumenttogoto-analyzer. I'm doing this to remove duplication of functionality, add configurability (the options ongoto-analyzerare not completely orthogonal but they are a lot better than at the moment), add testing and to try to slim downgoto-instrumentso that it is a bit more closer to it's original intent of performing goto-model to goto-model transformations. Please say if you disagree with this as a line of refactoring.This will also provide a more radical alternative than #7111 to resolving some of the issues with #7041.