Perform remove_returns pass before constant_propagator #7105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constant_propagator does not handle returns and gives unexpected results for examples including returns. Carrying out the remove_returns pass before contant propagation should resolve this issue.
thomasspriggs
requested review from
martin-cs,
chris-ryder and
peterschrammel
as code owners
martin-cs
approved these changes
Sep 6, 2022
tautschnig
requested changes
Sep 6, 2022
| @@ -1285,6 +1285,7 @@ void goto_instrument_parse_optionst::instrument_goto_program() | |||
| if(cmdline.isset("constant-propagator")) | |||
| { | |||
| do_indirect_call_and_rtti_removal(); | |||
| remove_returns(goto_model); | |||
There was a problem hiding this comment.
Please use do_remove_returns() instead.
Codecov Report
@@ Coverage Diff @@
## develop #7105 +/- ##
========================================
Coverage 77.87% 77.87%
========================================
Files 1576 1576
Lines 181588 181589 +1
========================================
+ Hits 141413 141415 +2
+ Misses 40175 40174 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This ensures that this pass is done only once and is shown in the logging.
TGWDB
approved these changes
Sep 6, 2022
|
@tautschnig Can you re-review this please? |
peterschrammel
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Good as a partial workaround. Eventually, the constant propgator should be replaced by functionality from goto-analyzer, as @martin-cs suggests.
tautschnig
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constant_propagator does not handle returns and gives unexpected
results for examples including returns. Carrying out the remove_returns
pass before contant propagation should resolve this issue.
This relates to #7041