CONTRACTS: look for dirty symbols in OTHER instructions.
#7085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traverse `OTHER` instructions subexpressions when the `statement` is `ID_array_*` or `ID_havoc_object`.
remi-delmas-3000
requested review from
tautschnig,
feliperodri and
SaswatPadhi
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #7085 +/- ##
========================================
Coverage 77.85% 77.85%
========================================
Files 1574 1574
Lines 181235 181245 +10
========================================
+ Hits 141099 141109 +10
Misses 40136 40136
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
feliperodri
added
aws
feliperodri
approved these changes
Aug 29, 2022
Comment on lines
+57
to
+76
| void collect_other(const goto_functiont &goto_function) | ||
| { | ||
| for(const auto &i : goto_function.body.instructions) | ||
| { | ||
| if(i.is_other()) | ||
| { | ||
| auto &statement = i.get_other().get_statement(); | ||
| if( | ||
| statement == ID_array_set || statement == ID_array_copy || | ||
| statement == ID_array_replace || statement == ID_array_equal || | ||
| statement == ID_havoc_object) | ||
| { | ||
| for(const auto &op : i.get_other().operands()) | ||
| { | ||
| find_dirty(op); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
LGTM, but why not incorporate this change into dirtyt class itself?
There was a problem hiding this comment.
Modifying dirtyt could have wide-ranging repercussions since many other analyses depend on it.
nwetzler
approved these changes
Aug 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traverse
OTHERinstructions subexpressions when thestatementisID_array_*orID_havoc_object, whichdirtytdoes not do and is needed for assigns clause checking when array operations are involved.Array ops are not supported in the current contract implementation so there is no impact on tests or performance.
This feature will be used in the upcoming dynamic frame condition checking PR.