Skip to content

CONTRACTS: Convenience updates for function_pointer_obeys_contract_exprt #7082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

remi-delmas-3000
Copy link
Collaborator

Add separate getters for the contract's symbol_expr and
the expression of its address. No impact on behaviour or performance.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • [N/A] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [N/A] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

…xprt`.

Add separate getters for the contract's `symbol_expr` and
the expression of its address.
@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #7082 (7386758) into develop (9bbce17) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #7082   +/-   ##
========================================
  Coverage    77.85%   77.85%           
========================================
  Files         1574     1574           
  Lines       181235   181235           
========================================
  Hits        141099   141099           
  Misses       40136    40136           
Impacted Files Coverage Δ
...c/solvers/smt2_incremental/convert_expr_to_smt.cpp 82.35% <ø> (ø)
..._incremental/smt2_incremental_decision_procedure.h 75.00% <ø> (ø)
src/ansi-c/c_expr.h 100.00% <100.00%> (ø)
src/ansi-c/c_typecheck_code.cpp 77.15% <100.00%> (ø)
src/goto-instrument/contracts/contracts.cpp 94.31% <100.00%> (ø)
...ncremental/smt2_incremental_decision_procedure.cpp 95.98% <100.00%> (ø)
...ncremental/smt2_incremental_decision_procedure.cpp 98.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jimgrundy jimgrundy added aws Bugs or features of importance to AWS CBMC users aws-high labels Aug 29, 2022
Copy link
Collaborator

@feliperodri feliperodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@feliperodri feliperodri added the Code Contracts Function and loop contracts label Aug 29, 2022
@remi-delmas-3000 remi-delmas-3000 merged commit 175a609 into diffblue:develop Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users aws-high Code Contracts Function and loop contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants