CONTRACTS: Allow ID_index expressions in history variables
#7060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaswatPadhi
added
enhancement
aws
SaswatPadhi
requested review from
tautschnig,
feliperodri,
remi-delmas-3000,
kroening and
chris-ryder
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #7060 +/- ##
========================================
Coverage 77.84% 77.84%
========================================
Files 1574 1574
Lines 181181 181191 +10
========================================
+ Hits 141045 141055 +10
Misses 40136 40136
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
martin-cs
approved these changes
Aug 15, 2022
feliperodri
requested changes
Aug 16, 2022
There was a problem hiding this comment.
@SaswatPadhi Good catch! Only a few minor questions before approval. Could you also add CONTRACTS: as a prefix in the title of the PR?
SaswatPadhi
force-pushed
the
history-vars-fix
branch
2 times, most recently
from
49bcbdb to
da4ead6
Compare
SaswatPadhi
force-pushed
the
history-vars-fix
branch
from
da4ead6 to
87a8ddb
Compare
SaswatPadhi
changed the title
ID_index expressions in history variablesID_index expressions in history variables
feliperodri
approved these changes
Aug 19, 2022
kroening
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although
ID_dereferenceexpressions were previously allowed within history variables,ID_indexexpressions were not. This PR adds support forID_indexexpressions as well.In addition, this PR also adds a compilation check for history variable parameters. Previously they were only checked during instrumentation, and bad parameters were silently accepted during compilation.
The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/My commit message includes data points confirming performance improvements (if claimed).White-space or formatting changes outside the feature-related changed lines are in commits of their own.