Deprecate and remove from the build an unused 2-line utility function #7030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
martin-cs
commented
Jul 22, 2022
martin-cs
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
martin-cs
force-pushed
the
fix/deprecate-rewrite-index
branch
from
ab6ab0f to
2d68a2c
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7030 +/- ##
========================================
Coverage 77.88% 77.88%
========================================
Files 1569 1569
Lines 180892 180892
========================================
Hits 140880 140880
Misses 40012 40012 Continue to review full report at Codecov.
|
|
@peterschrammel @chris-ryder any chance of a quick review? Should not take long. |
|
@chris-ryder No worries, thanks for the review! |
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Feb 20, 2023
The deprecating PR diffblue#7030 was merged on 2022-08-11, which is more than 6 months ago. This cleanup also ensures there are no dependencies on the object file left (an object file that the build wouldn't clean out anymore for the source was removed from its `Makefile` in the deprecating commit 2d68a2c).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.