kept consistency between parse options of cbmc and goto-instrument tools for link_to_library call #703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested changes
Mar 27, 2017
| status() << "Adding CPROVER library" << eom; | ||
| // add the library | ||
| status() << "Adding CPROVER library (" | ||
| << config.ansi_c.arch << ")" << eom; |
There was a problem hiding this comment.
As there are even more users of link_to_library: the status message should really just become part of the link_to_library implementation rather than replicating the code. Then the status() output should be removed at each callee.
lucasccordeiro
force-pushed
the
cprover-library-message
branch
from
c837c87 to
b14e4fe
Compare
lucasccordeiro
changed the title
lucasccordeiro
force-pushed
the
cprover-library-message
branch
2 times, most recently
from
482fff8 to
75ea506
Compare
Display the architecture information if the user intends to add the CPROVER library for code instrumentation. As a result, the status message is now part of the link_to_library implementation to avoid redundant code for the respective library call.
lucasccordeiro
force-pushed
the
cprover-library-message
branch
from
75ea506 to
ad384f1
Compare
tautschnig
approved these changes
Mar 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display the architecture information if the user intends to add the CPROVER library for code instrumentation.