-
Notifications
You must be signed in to change notification settings - Fork 274
Use cmdlinet::get_comma_separated_values where possible #6996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cmdlinet::get_comma_separated_values where possible #6996
Conversation
Codecov Report
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me :-) With just one completely optional comment about how the PR/commit is described. With apologies again for the tardiness!
@@ -1,6 +1,6 @@ | |||
CORE | |||
main.c | |||
--unwindset main.0:10,f.0:10,g.0:10,g.1:10 --unwinding-assertions | |||
--unwindset main.0:10,f.0:10 --unwindset g.0:10,g.1:10 --unwinding-assertions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting here, but more a comment for the PR and/or commit descriptions... But I was having a slightly hard time groking the intent of this PR until I saw this example here in the test case 👍 - So perhaps a clearer description might be something like:
Allow command line options that take values consisting of comma separated list to be
repeated and accumulated into a single list. For instance, making `--foo A,B,C,D` be
semantically equivalent to `--foo A,B --foo C,D`
Or words to that affect... not sure if its clearer or not to other people... but at least having the example in the description would be a big help :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I shamelessly copied this into the commit message!
Ensure that we accept repeat use of command-line options the arguments of which are comma-separated values. That is, allow command line options that take values consisting of comma separated lists to be repeated and accumulated into a single list. For instance, making `--foo A,B,C,D` be semantically equivalent to `--foo A,B --foo C,D`
d1977ca
to
e12b764
Compare
This is to make sure we accept repeat use of command-line options the
arguments of which are comma-separated values.