Skip to content

pretty-print expression instructions #6991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

kroening
Copy link
Member

@kroening kroening commented Jul 5, 2022

This adds pretty-printing for goto-program expression instructions.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This adds pretty-printing for goto-program expression instructions.
@kroening kroening force-pushed the goto_program_output_expression branch from 37dc489 to 09e1041 Compare July 5, 2022 09:41
@kroening kroening marked this pull request as ready for review July 5, 2022 10:26
@kroening kroening requested a review from peterschrammel as a code owner July 5, 2022 10:26
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #6991 (09e1041) into develop (8eef445) will decrease coverage by 0.03%.
The diff coverage is 84.57%.

@@             Coverage Diff             @@
##           develop    #6991      +/-   ##
===========================================
- Coverage    77.84%   77.81%   -0.04%     
===========================================
  Files         1570     1570              
  Lines       180439   180682     +243     
===========================================
+ Hits        140468   140601     +133     
- Misses       39971    40081     +110     
Impacted Files Coverage Δ
src/goto-instrument/contracts/contracts.h 100.00% <ø> (ø)
src/goto-instrument/horn_encoding.cpp 72.70% <0.00%> (+0.43%) ⬆️
src/goto-symex/goto_symex_state.cpp 91.71% <ø> (ø)
src/goto-symex/goto_symex_state.h 100.00% <ø> (ø)
src/util/replace_symbol.cpp 78.20% <36.95%> (-10.10%) ⬇️
src/linking/linking.cpp 58.71% <50.00%> (-0.03%) ⬇️
src/util/rename_symbol.cpp 76.82% <69.38%> (-3.00%) ⬇️
src/ansi-c/c_typecheck_base.cpp 82.50% <92.30%> (+1.34%) ⬆️
src/goto-symex/field_sensitivity.cpp 91.27% <96.00%> (-0.24%) ⬇️
src/goto-instrument/contracts/contracts.cpp 94.31% <98.87%> (+0.21%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c00319e...09e1041. Read the comment docs.

@kroening kroening merged commit 6d5ddf5 into develop Jul 5, 2022
@kroening kroening deleted the goto_program_output_expression branch July 5, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants