remove uses of base_type_eq #6989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kroening
commented
Jul 3, 2022
•
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
Codecov Report
@@ Coverage Diff @@
## develop #6989 +/- ##
===========================================
- Coverage 77.84% 77.82% -0.03%
===========================================
Files 1570 1569 -1
Lines 180439 180541 +102
===========================================
+ Hits 140468 140497 +29
- Misses 39971 40044 +73
Continue to review full report at Codecov.
|
tautschnig
approved these changes
Jul 4, 2022
kroening
force-pushed
the
remove_base_type
branch
from
a166cc2 to
ae165e1
Compare
kroening
changed the title
kroening
force-pushed
the
remove_base_type
branch
from
e055075 to
d457b14
Compare
tautschnig
approved these changes
Jul 5, 2022
| for(const exprt &op : expr.operands()) | ||
| { | ||
| const typet &op_type=op.type(); | ||
| if(base_type_eq(op_type, root_type, ns)) | ||
| if(op_type == root_type) |
There was a problem hiding this comment.
With this change the ns class member should be removed in a follow-up commit.
kroening
requested review from
martin-cs,
peterschrammel and
chris-ryder
as code owners
kroening
force-pushed
the
remove_base_type
branch
2 times, most recently
from
3747400 to
c729361
Compare
peterschrammel
approved these changes
Jul 5, 2022
kroening
force-pushed
the
remove_base_type
branch
from
c729361 to
75c8799
Compare
base_type_eq has been deprecated since 2019; a previous attempt to remove it (#4056) has failed.
kroening
force-pushed
the
remove_base_type
branch
from
75c8799 to
47cd689
Compare
tautschnig
reviewed
Jul 5, 2022
Comment on lines
+23
to
+22
| does_remove_constt::does_remove_constt(const goto_programt &goto_program) | ||
| : goto_program(goto_program) |
There was a problem hiding this comment.
Thank you for adding this commit. The documentation above, however, also needs to be updated (removing lines 21 and 22) to keep doxygen happy.
The last uses have been removed, and base_type_eq has been deprecated since 2019; a previous attempt to remove it (#4056) has failed.
kroening
force-pushed
the
remove_base_type
branch
from
47cd689 to
e42aaf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.