Skip to content

SMT2 back-end and solver: it's fp.isInfinite, not fp.isInf #6960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

We already had gotten this right in one place, but got in wrong in 5
other places.

Fixes: #1782

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

We already had gotten this right in one place, but got in wrong in 5
other places.

Fixes: diffblue#1782
@tautschnig tautschnig force-pushed the bugfixes/1782-smt2-isinfinite branch from 029584c to 27ac304 Compare June 23, 2022 10:18
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #6960 (27ac304) into develop (f239925) will increase coverage by 0.03%.
The diff coverage is 87.09%.

@@             Coverage Diff             @@
##           develop    #6960      +/-   ##
===========================================
+ Coverage    77.79%   77.83%   +0.03%     
===========================================
  Files         1568     1568              
  Lines       180347   180361      +14     
===========================================
+ Hits        140309   140378      +69     
+ Misses       40038    39983      -55     
Impacted Files Coverage Δ
src/solvers/smt2/smt2_parser.cpp 78.36% <33.33%> (+0.43%) ⬆️
src/solvers/lowering/byte_operators.cpp 92.60% <90.00%> (-0.11%) ⬇️
src/goto-programs/remove_function_pointers.cpp 92.79% <100.00%> (+0.09%) ⬆️
src/solvers/smt2/smt2_conv.cpp 68.87% <100.00%> (+0.97%) ⬆️
src/goto-checker/solver_factory.cpp 77.24% <0.00%> (+0.68%) ⬆️
src/util/ieee_float.h 87.65% <0.00%> (+2.46%) ⬆️
src/solvers/smt2/smt2_format.cpp 86.51% <0.00%> (+4.49%) ⬆️
src/solvers/flattening/boolbv_shift.cpp 89.65% <0.00%> (+10.34%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad2c6ca...27ac304. Read the comment docs.

@tautschnig tautschnig merged commit de154d9 into diffblue:develop Jun 23, 2022
@tautschnig tautschnig deleted the bugfixes/1782-smt2-isinfinite branch June 23, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--smt2 --fpa sometimes emits fp.isInf instead of fp.isInfinite
7 participants