CONTRACTS: detect and handle locals in assigns clause checking for loops #6947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-delmas-3000
added
bugfix
aws
remi-delmas-3000
requested review from
tautschnig,
feliperodri and
SaswatPadhi
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #6947 +/- ##
===========================================
+ Coverage 77.79% 77.83% +0.03%
===========================================
Files 1568 1569 +1
Lines 180347 180350 +3
===========================================
+ Hits 140309 140370 +61
+ Misses 40038 39980 -58
Continue to review full report at Codecov.
|
SaswatPadhi
suggested changes
Jun 17, 2022
| #include <vector> | ||
|
|
||
| /// Stores information about a goto function computed from its CFG, | ||
| /// together with a `target` iterator into the instructions of the function. |
There was a problem hiding this comment.
The iterator has been removed, comment cleanup needed
qinheping
reviewed
Jun 18, 2022
feliperodri
approved these changes
Jun 20, 2022
Comment on lines
+110
to
+109
| // For goto_functions | ||
| class function_cfg_infot : public cfg_infot |
There was a problem hiding this comment.
nitpick: why not add the implementation of these functions on a separate .c file?
There was a problem hiding this comment.
There's only three methods and two concrete classes, it seemed like overkill
remi-delmas-3000
force-pushed
the
cfg-info-loops
branch
2 times, most recently
from
591ed94 to
ddd32b4
Compare
When no assigns clause was provided, we were trying to infer variables touched by the loop and generate an assigns clause from that. Some of these variables could be locals, which have no meaning outside the loop, and we were trying to snapshot these variables outside of the loop. We now detect loop locals and remove them from the inferred frame condition the loop.
remi-delmas-3000
force-pushed
the
cfg-info-loops
branch
from
ddd32b4 to
00959cc
Compare
|
all changes made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6943.
When no assigns clause was provided, we were trying to infer variables touched by the loop and generate an assigns clause from that. Some of these variables could be locals, which have no meaning outside the loop, and we were trying to snapshot these variables outside of the loop. We now detect loop locals and remove them from the inferred frame condition the loop.