Skip to content

Remove unused option "simplify-if" #6919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

tautschnig
Copy link
Collaborator

Going back as far as version 2.9 of CBMC this option does not seem to be
read anywhere, it was just (unnecessarily) being set in the
front-end(s).

The command-line option "no-simplify-if" is left in place so as not to
break any scripts. A major version upgrade should take care of cleaning
this up as well.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Going back as far as version 2.9 of CBMC this option does not seem to be
read anywhere, it was just (unnecessarily) being set in the
front-end(s).

The command-line option "no-simplify-if" is left in place so as not to
break any scripts. A major version upgrade should take care of cleaning
this up as well.
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #6919 (4790e60) into develop (e42a46d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #6919   +/-   ##
========================================
  Coverage    77.78%   77.79%           
========================================
  Files         1568     1568           
  Lines       180269   180295   +26     
========================================
+ Hits        140230   140258   +28     
+ Misses       40039    40037    -2     
Impacted Files Coverage Δ
jbmc/src/jbmc/jbmc_parse_options.cpp 76.41% <ø> (+0.06%) ⬆️
src/cbmc/cbmc_parse_options.cpp 80.10% <ø> (+0.10%) ⬆️
src/util/config.cpp 57.85% <100.00%> (ø)
...t/solvers/smt2_incremental/convert_expr_to_smt.cpp 99.66% <0.00%> (+0.01%) ⬆️
...c/solvers/smt2_incremental/convert_expr_to_smt.cpp 87.80% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec66d39...4790e60. Read the comment docs.

@peterschrammel peterschrammel removed their assignment Jun 13, 2022
@NlightNFotis NlightNFotis merged commit 0d7d3c9 into diffblue:develop Jun 13, 2022
@tautschnig tautschnig deleted the cleanup/simplify-if branch June 13, 2022 18:13
@tautschnig tautschnig mentioned this pull request Nov 28, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants