-
Notifications
You must be signed in to change notification settings - Fork 274
String refinement: support pointers #6915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tautschnig
merged 4 commits into
diffblue:develop
from
tautschnig:bugfixes/use-bv_pointerst
Jun 13, 2022
Merged
String refinement: support pointers #6915
tautschnig
merged 4 commits into
diffblue:develop
from
tautschnig:bugfixes/use-bv_pointerst
Jun 13, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using null_message_handlert may hide errors.
This object is never used.
Draft
4 tasks
Using null_message_handlert hides errors, as the (now failing) regression test demonstrates.
We need to use bv_pointerst to convert address_of expressions.
776c1e5
to
b861c23
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6915 +/- ##
========================================
Coverage 77.78% 77.79%
========================================
Files 1568 1568
Lines 180269 180290 +21
========================================
+ Hits 140230 140252 +22
+ Misses 40039 40038 -1
Continue to review full report at Codecov.
|
romainbrenguier
approved these changes
Jun 9, 2022
kroening
approved these changes
Jun 11, 2022
peterschrammel
approved these changes
Jun 13, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use bv_pointerst to convert address_of expressions.
Please review commit-by-commit: this PR includes cleanup to reduce the number of uses of
null_message_handlert
, which can hide errors. A particular example of such errors was the use ofboolbvt
instead ofbv_pointerst
in string refinement.