Skip to content

Generate-function-bodies: generate a meaningful assertion #6898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented May 31, 2022

When using --generate-function-body with "assert-false" or
"assert-false-assume-false" make sure we produce a more meaningful
description than "assertion false." Instead, make the comment say
"undefined function should be unreachable."

Fixes: #6393

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

When using --generate-function-body with "assert-false" or
"assert-false-assume-false" make sure we produce a more meaningful
description than "assertion false." Instead, make the comment say
"undefined function should be unreachable."

Fixes: diffblue#6393
@tautschnig tautschnig force-pushed the bugfixes/6393-meaningful-assert branch from af60734 to 577b0ec Compare May 31, 2022 08:28
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #6898 (577b0ec) into develop (f7a33df) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #6898      +/-   ##
===========================================
- Coverage    77.81%   77.81%   -0.01%     
===========================================
  Files         1568     1568              
  Lines       179985   179975      -10     
===========================================
- Hits        140054   140044      -10     
  Misses       39931    39931              
Impacted Files Coverage Δ
src/goto-instrument/generate_function_bodies.cpp 93.98% <ø> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bf3ea6...577b0ec. Read the comment docs.

@tautschnig tautschnig merged commit 20deba0 into diffblue:develop May 31, 2022
@tautschnig tautschnig deleted the bugfixes/6393-meaningful-assert branch May 31, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difficulty using "assert(false)" for unimplemented functions
5 participants