Skip to content

Replace all uses of goto_programt::output_instruction #6896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2022

Conversation

tautschnig
Copy link
Collaborator

output_instruction is deprecated in favour of output, which requires
less contextual information. Replace all uses of output_instruction by
calls to output and do any cleanup that is now possible.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #6896 (f7a33df) into develop (b4d69dd) will decrease coverage by 0.00%.
The diff coverage is 27.08%.

@@             Coverage Diff             @@
##           develop    #6896      +/-   ##
===========================================
- Coverage    77.81%   77.81%   -0.01%     
===========================================
  Files         1568     1568              
  Lines       179980   179985       +5     
===========================================
- Hits        140055   140054       -1     
- Misses       39925    39931       +6     
Impacted Files Coverage Δ
src/analyses/flow_insensitive_analysis.cpp 74.64% <ø> (ø)
src/analyses/local_bitvector_analysis.cpp 73.98% <0.00%> (ø)
src/analyses/local_may_alias.cpp 63.80% <0.00%> (ø)
src/analyses/sese_regions.cpp 97.05% <ø> (ø)
src/analyses/static_analysis.cpp 46.69% <ø> (ø)
src/goto-analyzer/unreachable_instructions.cpp 89.01% <ø> (ø)
src/goto-diff/change_impact.cpp 0.00% <0.00%> (ø)
src/goto-diff/unified_diff.cpp 0.00% <0.00%> (ø)
...ument/accelerate/enumerating_loop_acceleration.cpp 62.50% <ø> (ø)
...o-instrument/accelerate/polynomial_accelerator.cpp 0.00% <ø> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f403924...f7a33df. Read the comment docs.

output_instruction is deprecated in favour of output, which requires
less contextual information. Replace all uses of output_instruction by
calls to output and do any cleanup that is now possible.
@tautschnig tautschnig force-pushed the cleanup/output_instruction branch from 957de91 to f7a33df Compare May 30, 2022 20:01
@tautschnig tautschnig merged commit 8bf3ea6 into diffblue:develop May 31, 2022
@tautschnig tautschnig deleted the cleanup/output_instruction branch May 31, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants