Skip to content

introduce goto_programt::instructiont::output #6894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2022

Conversation

kroening
Copy link
Member

This introduces goto_programt::instructiont::output as a more idiomatic
substitute for goto_programt::output_instruction. The identifier
parameter is no longer in use, and is thus removed from the API.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This introduces goto_programt::instructiont::output as a more idiomatic
substitute for goto_programt::output_instruction.  The namespace and
'identifier' parameters are no longer in use, and are thus removed from the
API.
@kroening kroening force-pushed the goto_instruction_output branch from 5e376e2 to b4d69dd Compare May 29, 2022 08:25
@kroening kroening marked this pull request as ready for review May 29, 2022 09:13
@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #6894 (b4d69dd) into develop (000c152) will increase coverage by 0.00%.
The diff coverage is 92.43%.

@@           Coverage Diff            @@
##           develop    #6894   +/-   ##
========================================
  Coverage    77.80%   77.81%           
========================================
  Files         1567     1568    +1     
  Lines       179921   179980   +59     
========================================
+ Hits        139993   140055   +62     
+ Misses       39928    39925    -3     
Impacted Files Coverage Δ
src/memory-analyzer/gdb_api.h 100.00% <ø> (ø)
src/solvers/flattening/boolbv.h 62.50% <ø> (ø)
..._incremental/smt2_incremental_decision_procedure.h 75.00% <ø> (ø)
src/solvers/flattening/boolbv_quantifier.cpp 93.27% <50.00%> (+0.84%) ⬆️
src/goto-programs/goto_program.cpp 81.71% <75.00%> (+0.42%) ⬆️
...t/solvers/smt2_incremental/convert_expr_to_smt.cpp 99.65% <96.72%> (-0.23%) ⬇️
src/ansi-c/expr2c.cpp 67.63% <100.00%> (ø)
src/goto-analyzer/unreachable_instructions.cpp 89.01% <100.00%> (-1.94%) ⬇️
src/goto-programs/goto_program.h 90.75% <100.00%> (+0.05%) ⬆️
src/goto-programs/show_goto_functions.cpp 76.31% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5303a9d...b4d69dd. Read the comment docs.

@kroening kroening merged commit f403924 into develop May 29, 2022
@kroening kroening deleted the goto_instruction_output branch May 29, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants