GOTO programs do not have code-typed struct members #6892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
martin-cs,
peterschrammel,
romainbrenguier and
kroening
as code owners
tautschnig
force-pushed
the
cleanup/no-code
branch
from
1e7b691 to
8168170
Compare
Codecov ReportBase: 78.02% // Head: 78.04% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6892 +/- ##
===========================================
+ Coverage 78.02% 78.04% +0.02%
===========================================
Files 1625 1624 -1
Lines 187427 187404 -23
===========================================
+ Hits 146231 146253 +22
+ Misses 41196 41151 -45
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
danielsn
reviewed
May 27, 2022
| first = false; | ||
| else | ||
| { | ||
| if(last_size + 40 < dest.size()) |
There was a problem hiding this comment.
Yes, it's the same constant (and approach) that expr2ct::convert_struct uses for pretty-printing (and the same is true for arrays). Could be replaced by a named constant, but I'll just create an issue for the readability of this code needs improvement: #6900.
|
FYI: Looks like Kani also creates |
tautschnig
force-pushed
the
cleanup/no-code
branch
from
8168170 to
356bcf4
Compare
peterschrammel
approved these changes
Jul 18, 2022
tautschnig
force-pushed
the
cleanup/no-code
branch
from
356bcf4 to
646d5c0
Compare
tautschnig
force-pushed
the
cleanup/no-code
branch
from
646d5c0 to
2971262
Compare
Cleanup of an unnecessary branch: Any such component would be a pointer/reference, not an actual code-typed element.
Whitespace changes only, no change in behaviour.
Cleanup of unnecessary branches: Any such component would be a function pointer, not an actual code-typed element.
It's only the C++ front-end that puts methods in struct members, and this should not leak into GOTO programs. We can, therefore, clean up a number of unnecessary branches. Fixes: diffblue#6984
tautschnig
force-pushed
the
cleanup/no-code
branch
from
2971262 to
4c8e44b
Compare
|
What's the blocking issue here? Are we just waiting on a code review? |
feliperodri
added
aws
kroening
approved these changes
Nov 10, 2022
peterschrammel
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's only the C++ front-end that puts methods in struct members, and
this should not leak into GOTO programs. We can, therefore, clean up a
number of unnecessary branches.
Please review commit-by-commit.
Fixes #6984.