Skip to content

Add get value response validation for smt bv constant descriptors #6879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

thomasspriggs
Copy link
Contributor

@thomasspriggs thomasspriggs commented May 24, 2022

This PR adds get value response validation for smt bv constant descriptors. These changes are split from #6866

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #6879 (79169e0) into develop (f9456fe) will increase coverage by 0.00%.
The diff coverage is 88.82%.

@@           Coverage Diff            @@
##           develop    #6879   +/-   ##
========================================
  Coverage    77.79%   77.80%           
========================================
  Files         1567     1567           
  Lines       179818   179915   +97     
========================================
+ Hits        139895   139987   +92     
- Misses       39923    39928    +5     
Impacted Files Coverage Δ
...goto-harness/memory_snapshot_harness_generator.cpp 76.17% <0.00%> (ø)
src/goto-programs/string_instrumentation.cpp 25.11% <0.00%> (-0.06%) ⬇️
src/cpp/expr2cpp.cpp 42.97% <33.33%> (+0.28%) ⬆️
src/cpp/cpp_typecheck_conversions.cpp 84.97% <52.94%> (-0.18%) ⬇️
src/pointer-analysis/value_set_fi.cpp 69.82% <71.42%> (-0.02%) ⬇️
...lvers/smt2_incremental/smt_response_validation.cpp 97.87% <97.82%> (+0.53%) ⬆️
jbmc/src/java_bytecode/ci_lazy_methods_needed.cpp 98.41% <100.00%> (ø)
jbmc/src/java_bytecode/convert_java_nondet.cpp 79.72% <100.00%> (+0.27%) ⬆️
jbmc/src/java_bytecode/expr2java.cpp 86.25% <100.00%> (ø)
...bmc/src/java_bytecode/java_bytecode_parse_tree.cpp 9.90% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a702e77...79169e0. Read the comment docs.

@NlightNFotis NlightNFotis merged commit 679ab3f into diffblue:develop May 25, 2022
@thomasspriggs thomasspriggs deleted the tas/improved_get_value_response_validation branch May 25, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants