Goto-symex: record value-at-declaration in the back-end #6875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
kroening,
peterschrammel and
romainbrenguier
as code owners
Declarations are printed as part of a symex trace, and come with both a symbol being declared as well as an (unconstrained) initial value for that symbol. The decision procedure must learn about the initial value to include it in the model. Else, the trace value would just be question marks. Fixes: diffblue#6845
tautschnig
force-pushed
the
bugfixes/6845-part-2-decl
branch
from
666b787 to
0ce746a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6875 +/- ##
========================================
Coverage 77.79% 77.80%
========================================
Files 1567 1567
Lines 179818 179820 +2
========================================
+ Hits 139895 139912 +17
+ Misses 39923 39908 -15
Continue to review full report at Codecov.
|
peterschrammel
approved these changes
May 31, 2022
| @@ -389,6 +389,8 @@ void symex_target_equationt::convert_decls( | |||
| // The result is not used, these have no impact on | |||
| // the satisfiability of the formula. | |||
| decision_procedure.handle(step.cond_expr); | |||
There was a problem hiding this comment.
Is the handle for the cond_expr needed at all then?
There was a problem hiding this comment.
Yes, one of them is ssa_lhs, the other is ssa_full_lhs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declarations are printed as part of a symex trace, and come with both a
symbol being declared as well as an (unconstrained) initial value for
that symbol. The decision procedure must learn about the initial value
to include it in the model. Else, the trace value would just be question
marks.
Fixes: #6845