Skip to content

add further formatters #6874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2022
Merged

add further formatters #6874

merged 4 commits into from
May 24, 2022

Conversation

kroening
Copy link
Member

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening force-pushed the more_formatters2 branch from c41a2dd to b3552fe Compare May 20, 2022 09:26
@kroening kroening marked this pull request as ready for review May 20, 2022 09:59
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #6874 (f9456fe) into develop (862affb) will increase coverage by 0.00%.
The diff coverage is 87.09%.

@@           Coverage Diff            @@
##           develop    #6874   +/-   ##
========================================
  Coverage    77.79%   77.79%           
========================================
  Files         1567     1567           
  Lines       179772   179818   +46     
========================================
+ Hits        139857   139895   +38     
- Misses       39915    39923    +8     
Impacted Files Coverage Δ
src/goto-symex/symex_slice_class.h 100.00% <ø> (ø)
src/util/format_expr.cpp 87.35% <65.21%> (-1.61%) ⬇️
src/goto-symex/slice.cpp 63.54% <75.00%> (-0.89%) ⬇️
src/goto-programs/goto_program.cpp 81.29% <94.11%> (+0.67%) ⬆️
src/cpp/cpp_convert_type.cpp 73.41% <100.00%> (-0.16%) ⬇️
src/cpp/cpp_typecheck_type.cpp 75.75% <100.00%> (+1.35%) ⬆️
src/goto-symex/show_program.cpp 93.78% <100.00%> (+0.07%) ⬆️
src/solvers/flattening/boolbv_member.cpp 100.00% <100.00%> (+2.43%) ⬆️
src/solvers/smt2/smt2_conv.cpp 67.25% <100.00%> (-0.03%) ⬇️
src/util/pointer_expr.h 88.11% <100.00%> (+0.19%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68cbf7a...f9456fe. Read the comment docs.

kroening added 4 commits May 23, 2022 22:30
This is a cosmetic change to the formatter for goto-instruction output
statements.
This makes default-formatted expressions less verbose.
This adds the obvious cast function for object_size_exprt.
This adds formatters for object_address, object_size, pointer_offset, and
field_address.
@kroening kroening force-pushed the more_formatters2 branch from b3552fe to f9456fe Compare May 23, 2022 21:31
@kroening kroening merged commit bd45729 into develop May 24, 2022
@kroening kroening deleted the more_formatters2 branch May 24, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants