Use boolbv_width::get_member #6861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
martin-cs,
kroening and
peterschrammel
as code owners
tautschnig
force-pushed
the
cleanup/use-get_member
branch
from
d13e177 to
171581b
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6861 +/- ##
===========================================
- Coverage 77.78% 77.78% -0.01%
===========================================
Files 1567 1567
Lines 179701 179762 +61
===========================================
+ Hits 139789 139833 +44
- Misses 39912 39929 +17
Continue to review full report at Codecov.
|
boolbv_widtht kept track of the offset and width of struct members, but we never used that information. Avoid re-computing the same information (without caching!) in convert_member_struct and thereby simplify its implementation to the extent that inlining it made the code even simpler. smt_convt used yet another approach via member_offset_bits when really it should be using boolbv_widtht::get_member instead.
tautschnig
force-pushed
the
cleanup/use-get_member
branch
from
171581b to
58f3053
Compare
tautschnig
requested review from
thomasspriggs,
NlightNFotis and
TGWDB
as code owners
peterschrammel
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boolbv_widtht kept track of the offset and width of struct members, but
we never used that information. Avoid re-computing the same information
(without caching!) in convert_member_struct and thereby simplify its
implementation to the extent that inlining it made the code even
simpler.