Skip to content

protect goto_instructiont::guard #6853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2022
Merged

protect goto_instructiont::guard #6853

merged 1 commit into from
May 17, 2022

Conversation

kroening
Copy link
Member

This protects a field of goto_instructiont, in favor of using the
recommended accessor methods.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening force-pushed the protect_guard branch 6 times, most recently from f9ab8c0 to f7e0e11 Compare May 13, 2022 04:36
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #6853 (54b88f6) into develop (a9ddceb) will increase coverage by 0.00%.
The diff coverage is 70.14%.

@@           Coverage Diff            @@
##           develop    #6853   +/-   ##
========================================
  Coverage    77.78%   77.79%           
========================================
  Files         1567     1567           
  Lines       179701   179711   +10     
========================================
+ Hits        139788   139798   +10     
  Misses       39913    39913           
Impacted Files Coverage Δ
src/analyses/cfg_dominators.h 100.00% <ø> (ø)
src/analyses/interval_analysis.cpp 0.00% <0.00%> (ø)
src/analyses/invariant_set_domain.cpp 0.00% <0.00%> (ø)
src/goto-instrument/dot.cpp 0.00% <0.00%> (ø)
src/goto-programs/remove_returns.cpp 98.15% <ø> (ø)
src/goto-programs/show_goto_functions_xml.cpp 0.00% <0.00%> (ø)
src/goto-symex/symex_goto.cpp 97.12% <ø> (ø)
src/goto-symex/symex_main.cpp 86.97% <0.00%> (ø)
src/goto-symex/solver_hardness.cpp 53.00% <11.11%> (ø)
src/goto-instrument/wmm/goto2graph.cpp 54.49% <12.50%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 970cc26...54b88f6. Read the comment docs.

@kroening kroening marked this pull request as ready for review May 13, 2022 13:38
@kroening kroening removed their assignment May 13, 2022
This protects a field of goto_instructiont, in favor of using the
recommended accessor methods.
@peterschrammel peterschrammel removed their assignment May 17, 2022
@kroening kroening merged commit 44273a3 into develop May 17, 2022
@kroening kroening deleted the protect_guard branch May 17, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants