Skip to content

Make compiling with DEBUG actually work #6848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2022

Conversation

tautschnig
Copy link
Collaborator

Various places use #ifdef DEBUG, which we don't experiment with on a
regular basis. Fix syntax errors that crept in over time.

This is the result of actually enabling -DDEBUG by accident, I do not see real value in testing this in CI for we don't even use the same macro in all places.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Various places use #ifdef DEBUG, which we don't experiment with on a
regular basis. Fix syntax errors that crept in over time.
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #6848 (6baffa3) into develop (3df1868) will increase coverage by 0.74%.
The diff coverage is 88.96%.

@@             Coverage Diff             @@
##           develop    #6848      +/-   ##
===========================================
+ Coverage    77.04%   77.79%   +0.74%     
===========================================
  Files         1594     1567      -27     
  Lines       185287   179707    -5580     
===========================================
- Hits        142763   139797    -2966     
+ Misses       42524    39910    -2614     
Impacted Files Coverage Δ
jbmc/src/jbmc/jbmc_parse_options.cpp 76.51% <ø> (+0.53%) ⬆️
...riable-sensitivity/variable_sensitivity_domain.cpp 90.00% <ø> (ø)
src/cbmc/cbmc_parse_options.cpp 79.90% <ø> (+0.87%) ⬆️
src/goto-instrument/accelerate/accelerate.cpp 31.94% <ø> (ø)
.../goto-instrument/accelerate/acceleration_utils.cpp 2.22% <ø> (ø)
src/goto-instrument/accelerate/trace_automaton.cpp 0.00% <ø> (ø)
src/goto-instrument/cover_basic_blocks.h 100.00% <ø> (ø)
src/goto-instrument/source_lines.h 100.00% <ø> (ø)
src/goto-instrument/unwind.h 100.00% <ø> (ø)
src/goto-instrument/wmm/data_dp.cpp 75.71% <ø> (ø)
... and 90 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c83dada...6baffa3. Read the comment docs.

@peterschrammel peterschrammel removed their assignment May 17, 2022
@tautschnig tautschnig merged commit 6061711 into diffblue:develop May 17, 2022
@tautschnig tautschnig deleted the cleanup/debug branch May 17, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants