-
Notifications
You must be signed in to change notification settings - Fork 273
Updates to compiling instructions for GCC 6 #682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -36,7 +36,7 @@ We assume that you have a Debian/Ubuntu or Red Hat-like distribution. | |||
|
|||
On Red Hat/Fedora or derivates, do | |||
|
|||
yum install gcc gcc-c++ flex bison perl-libwww-perl patch | |||
yum install gcc gcc-c++ flex bison perl-libwww-perl patch devtoolset-6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that when you use devtoolset-6
you can remove some of dependencies. YUM should be fine with
yum install flex bison perl-libwww-perl patch devtoolset-6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing gcc and gcc-c++ makes the regression tests fail without the devtoolset-6 enabled. I cannot immediately see if this is a problem with the tests or with the cbmc binary. @kroening please let me know if you would like me to investigate further or you are happy with the instructions as is.
|
||
On Redhat/Fedora etc., do | ||
|
||
cd cbmc-git/src | ||
make minisat2-download | ||
make CXX=g++-6 | ||
scl enable devtoolset-6 bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and then you probably need to run this before first make
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed this is required, if the above requested change is made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's go for the "scl enable devtoolset-6 bash" change; it's better that the regressions work out-of-the box
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which case I am happy with the state of this PR. The version here will ensure that the regression tests run under most scenarios.
Please let me know if you need anything else.
The current instructions don't work for compiling on RedHat and need a small tweak to work for Ubuntu. I have tested these instructions on RedHat 7 and Ubuntu 16.10.