-
Notifications
You must be signed in to change notification settings - Fork 274
Add new documentation for homebrew tap #6817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #6817 +/- ##
=========================================
Coverage 77.00% 77.01%
=========================================
Files 1594 1594
Lines 184359 184954 +595
=========================================
+ Hits 141966 142438 +472
- Misses 42393 42516 +123
Continue to review full report at Codecov.
|
Note that this partially fixes #6750 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
49b63af
to
eeec637
Compare
6573bef
to
b6614ff
Compare
doc/ADR/homebrew_tap.md
Outdated
|
||
## Developer instructions | ||
|
||
1. First of all, you need to create a new tap locally: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under what circumstances do we need to create a tap locally? Is this part of creating an entirely separate tap on github, or modifying the tap that already exists to add new versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that was there just for documentation purposes.
Most likely you won't need to do that
It's a one off for setting up a new tap, and as we already have one, (it's highly likely) no one's going to need to do that again.
cd4139b
to
761f7fb
Compare
This PR adds new documentation for both users and developers of the CBMC tap.