Skip to content

Crangler: also apply remove-static to declarations #6816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

tautschnig
Copy link
Collaborator

Taking functions out of file-local scope requires removing the "static"
keyword from both definitions as well as declarations.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Taking functions out of file-local scope requires removing the "static"
keyword from both definitions as well as declarations.
@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #6816 (c5f0f36) into develop (5ff1a04) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #6816   +/-   ##
========================================
  Coverage    77.00%   77.00%           
========================================
  Files         1594     1594           
  Lines       184348   184350    +2     
========================================
+ Hits        141954   141957    +3     
+ Misses       42394    42393    -1     
Impacted Files Coverage Δ
src/goto-instrument/contracts/memory_predicates.h 100.00% <ø> (ø)
src/crangler/c_wrangler.cpp 59.33% <100.00%> (+0.75%) ⬆️
src/goto-instrument/contracts/contracts.cpp 93.89% <100.00%> (ø)
...rc/goto-instrument/contracts/memory_predicates.cpp 85.49% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abc4e01...c5f0f36. Read the comment docs.

@kroening kroening merged commit 94b81b2 into diffblue:develop Apr 19, 2022
@tautschnig tautschnig deleted the bugfixes/crangler-static branch April 20, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants