Skip to content

Add pointer offset and object expression unit tests #6803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thomasspriggs
Copy link
Contributor

This PR adds pointer offset and object expression unit tests.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #6803 (351cecb) into develop (69ac490) will increase coverage by 0.01%.
The diff coverage is 94.50%.

@@             Coverage Diff             @@
##           develop    #6803      +/-   ##
===========================================
+ Coverage    76.97%   76.99%   +0.01%     
===========================================
  Files         1593     1594       +1     
  Lines       184104   184263     +159     
===========================================
+ Hits        141718   141872     +154     
- Misses       42386    42391       +5     
Impacted Files Coverage Δ
.../goto-instrument/accelerate/acceleration_utils.cpp 2.22% <0.00%> (ø)
src/goto-programs/interpreter_evaluate.cpp 33.88% <0.00%> (+0.11%) ⬆️
src/util/simplify_expr_class.h 90.47% <ø> (ø)
src/util/std_expr.h 93.18% <50.00%> (-0.48%) ⬇️
src/util/validate_expressions.cpp 93.75% <90.00%> (-1.71%) ⬇️
...o-instrument/contracts/instrument_spec_assigns.cpp 97.37% <100.00%> (ø)
src/goto-instrument/contracts/utils.cpp 89.36% <100.00%> (+0.11%) ⬆️
src/pointer-analysis/value_set.cpp 83.31% <100.00%> (ø)
src/solvers/flattening/bv_pointers.cpp 83.09% <100.00%> (+0.06%) ⬆️
src/solvers/smt2/smt2_conv.cpp 67.48% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b7340...351cecb. Read the comment docs.

@NlightNFotis NlightNFotis merged commit 113195d into diffblue:develop Apr 14, 2022
@thomasspriggs thomasspriggs deleted the tas/pointer_expression_tests branch April 14, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants