Coverage-report fixes #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/goto-programs/remove_returns.cpp
Outdated
| @@ -269,6 +269,46 @@ void remove_returns(goto_modelt &goto_model) | |||
|
|
|||
| /*******************************************************************\ | |||
|
|
|||
| Function: original_code_type | |||
There was a problem hiding this comment.
does not match function name
remove_returns would cause return types that appear inconsistent to the user.
symex_bmct may now re-implement merge_goto to observe each merge, just like loop unwinding is reported.
tautschnig
force-pushed
the
coverage-fixes
branch
from
975c519 to
b7b0059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coverage reporting introduced in 910ca64 had some precision bugs and was not reporting branch coverage properly.