Skip to content

CI jobs: upgrade CVC5 to 1.0.0 [depends-on: #6790] #6791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2022
Merged

CI jobs: upgrade CVC5 to 1.0.0 [depends-on: #6790] #6791

merged 2 commits into from
Apr 9, 2022

Conversation

tautschnig
Copy link
Collaborator

CVC5 version 1 has been released on 2022-04-06.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Apr 8, 2022
@tautschnig
Make sure all CI jobs running tests have CVC5 installed
54b54e9 
As of diffblue#6777, the codecov job kept failing for CVC5 wasn't available in
this job. The same would have been true of release jobs, but we haven't
had one since diffblue#6777 was merged.
@tautschnig
CI jobs: upgrade CVC5 to 1.0.0
b7c6692 
CVC5 version 1 has been released on 2022-04-06.
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #6791 (b7c6692) into develop (e02f4da) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #6791   +/-   ##
========================================
  Coverage    76.90%   76.90%           
========================================
  Files         1590     1590           
  Lines       183971   183969    -2     
========================================
  Hits        141486   141486           
+ Misses       42485    42483    -2
Impacted Files Coverage Δ
src/goto-instrument/contracts/contracts.cpp 93.84% <100.00%> (+0.14%) ⬆️
src/analyses/goto_rw.cpp 63.20% <0.00%> (-0.09%) ⬇️
src/goto-cc/ms_cl_cmdline.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3e4096...b7c6692. Read the comment docs.

TGWDB
TGWDB approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@TGWDB TGWDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tautschnig tautschnig marked this pull request as ready for review April 9, 2022 18:28
@tautschnig tautschnig requested a review from a team as a code owner April 9, 2022 18:28
@tautschnig tautschnig merged commit 1a4c66e into diffblue:develop Apr 9, 2022
@tautschnig tautschnig deleted the features/cvc5-1 branch April 9, 2022 18:28
@tautschnig tautschnig mentioned this pull request Apr 9, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TGWDB TGWDB TGWDB approved these changes

Assignees

@tautschnig tautschnig

Labels
CI dependent - do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tautschnig @TGWDB