CONTRACTS: Fix targett comparison in loop instrumentation #6782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
reviewed
Apr 5, 2022
There was a problem hiding this comment.
I don't quite agree with the commit message: https://github.com/diffblue/cbmc/blob/develop/src/goto-programs/goto_program.h#L1240..L1245 is what is being invoked here. That's not undefined behaviour, but will be behaviour that may not be as reproducible.
And then also the issue that I commented on below, which might be what resulted in breaking some tests.
Inequality comparison on targett iterators are overloaded to compare raw pointers instead. This led to flakiness: incorrect instrumentation of loop contracts in some runs.
SaswatPadhi
changed the title
|
Thanks for the review, @tautschnig and @feliperodri. @tautschnig: I think I have addressed all your comments now. |
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Apr 6, 2022
This makes sure no one can inadvertently use less-than comparison on those iterators, which may lead to non-reproducible behaviour (see diffblue#6782).
4 tasks
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Apr 9, 2022
This makes sure no one can inadvertently use less-than comparison on those iterators, which may lead to non-reproducible behaviour (see diffblue#6782).
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Apr 9, 2022
This makes sure no one can inadvertently use less-than comparison on those iterators, which may lead to non-reproducible behaviour (see diffblue#6782).
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Jan 11, 2023
This makes sure no one can inadvertently use less-than comparison on those iterators, which may lead to non-reproducible behaviour (see diffblue#6782).
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
May 17, 2023
This makes sure no one can inadvertently use less-than comparison on those iterators, which may lead to non-reproducible behaviour (see diffblue#6782).
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
May 22, 2023
This makes sure no one can inadvertently use less-than comparison on those iterators, which may lead to non-reproducible behaviour (see diffblue#6782).
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
May 23, 2023
This makes sure no one can inadvertently use less-than comparison on those iterators, which may lead to non-reproducible behaviour (see diffblue#6782).
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
May 30, 2023
This makes sure no one can inadvertently use less-than comparison on those iterators, which may lead to non-reproducible behaviour (see diffblue#6782).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An inequality comparison on iterators was leading to undefined behavior and flakiness: incorrect instrumentation loop contracts.
Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/My commit message includes data points confirming performance improvements (if claimed).