Skip to content

Install cvc5 on Windows pull request jobs #6778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

thomasspriggs
Copy link
Contributor

@thomasspriggs thomasspriggs commented Apr 1, 2022

This PR installs cvc5 on Windows pull request jobs, so that we can test with cvc5 across all platforms.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The cvc5 github repository has begun offering Windows builds on their
release page. Updating the version used will enable us to supply cvc5
for the cbmc Windows jobs as well.
So that we can test with cvc5 across all platforms.
@thomasspriggs thomasspriggs marked this pull request as ready for review April 1, 2022 12:55
@thomasspriggs thomasspriggs requested a review from a team as a code owner April 1, 2022 12:55
@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #6778 (6127938) into develop (f1dd8db) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #6778   +/-   ##
========================================
  Coverage    76.90%   76.90%           
========================================
  Files         1590     1590           
  Lines       183970   183970           
========================================
  Hits        141485   141485           
  Misses       42485    42485           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce7e74c...6127938. Read the comment docs.

@thomasspriggs thomasspriggs merged commit 2bf999e into diffblue:develop Apr 1, 2022
@thomasspriggs thomasspriggs deleted the tas/cvc5_windows branch April 1, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants