Skip to content

Add missing #include <cassert> #6757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

tautschnig
Copy link
Collaborator

cassert is implicitly provided via nonstd/optional, but this will change
with the move to std::optional. The even better fix would be the
replacement of all uses of assert(...) in these files, but this is a
larger endeavour.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

cassert is implicitly provided via nonstd/optional, but this will change
with the move to std::optional. The even better fix would be the
replacement of all uses of assert(...) in these files, but this is a
larger endeavour.
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #6757 (1828a14) into develop (c0f179c) will increase coverage by 0.02%.
The diff coverage is 86.88%.

@@             Coverage Diff             @@
##           develop    #6757      +/-   ##
===========================================
+ Coverage    76.87%   76.89%   +0.02%     
===========================================
  Files         1590     1590              
  Lines       183887   183977      +90     
===========================================
+ Hits        141364   141475     +111     
+ Misses       42523    42502      -21     
Impacted Files Coverage Δ
src/ansi-c/c_typecheck_expr.cpp 77.06% <ø> (ø)
src/ansi-c/c_typecheck_initializer.cpp 76.49% <ø> (ø)
src/ansi-c/c_typecheck_type.cpp 77.08% <ø> (ø)
src/ansi-c/goto_check_c.cpp 91.47% <ø> (-0.15%) ⬇️
src/cpp/cpp_instantiate_template.cpp 79.16% <ø> (ø)
src/cpp/cpp_typecheck.cpp 79.22% <ø> (ø)
src/cpp/cpp_typecheck_code.cpp 80.59% <ø> (ø)
src/cpp/cpp_typecheck_compound_type.cpp 86.84% <ø> (ø)
src/cpp/cpp_typecheck_constructor.cpp 89.10% <ø> (ø)
src/cpp/cpp_typecheck_conversions.cpp 85.14% <ø> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 629d029...1828a14. Read the comment docs.

@tautschnig
Copy link
Collaborator Author

Closing as #6754 will now take care of all remaining assert statements.

@tautschnig tautschnig closed this Mar 25, 2022
@tautschnig tautschnig deleted the cleanup/cassert branch March 25, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants