Skip to content

Remove unqualified use of nullopt [blocks: #6749] #6756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2022

Conversation

tautschnig
Copy link
Collaborator

When moving to std::optional we'd have to use std::nullopt. Avoid doing
so by using {} instead, which works today and will work with
std::optional.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

When moving to std::optional we'd have to use std::nullopt. Avoid doing
so by using {} instead, which works today and will work with
std::optional.
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #6756 (7491954) into develop (c0f179c) will increase coverage by 0.02%.
The diff coverage is 88.11%.

@@             Coverage Diff             @@
##           develop    #6756      +/-   ##
===========================================
+ Coverage    76.87%   76.89%   +0.02%     
===========================================
  Files         1590     1590              
  Lines       183887   183973      +86     
===========================================
+ Hits        141364   141473     +109     
+ Misses       42523    42500      -23     
Impacted Files Coverage Δ
src/ansi-c/goto_check_c.cpp 91.47% <ø> (-0.15%) ⬇️
src/memory-analyzer/gdb_api.h 100.00% <ø> (ø)
src/solvers/flattening/boolbv.h 62.50% <ø> (ø)
src/solvers/flattening/boolbv_quantifier.cpp 93.27% <50.00%> (+0.84%) ⬆️
...c/solvers/smt2_incremental/convert_expr_to_smt.cpp 72.09% <79.48%> (+3.07%) ⬆️
src/analyses/goto_rw.cpp 62.83% <100.00%> (+0.47%) ⬆️
src/ansi-c/expr2c.cpp 67.36% <100.00%> (+0.74%) ⬆️
src/goto-analyzer/unreachable_instructions.cpp 90.95% <100.00%> (ø)
src/goto-programs/builtin_functions.cpp 58.35% <100.00%> (+1.48%) ⬆️
src/util/edit_distance.cpp 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 629d029...7491954. Read the comment docs.

@tautschnig tautschnig changed the title Remove unqualified use of nullopt Remove unqualified use of nullopt [blocks: #6749] Mar 25, 2022
@tautschnig
Copy link
Collaborator Author

@chris-ryder I’ve got three approving reviews here, but strictly need yours as well. Could you please take a look?

@chris-ryder
Copy link

@tautschnig Apologies for the tardiness! :-)

@tautschnig tautschnig merged commit 76897ae into diffblue:develop May 27, 2022
@tautschnig tautschnig deleted the cleanup/nullopt branch May 27, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants