Skip to content

Add separate overflow expr classes #6744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 23, 2022
Merged

Add separate overflow expr classes #6744

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
19db9a0
Add `binary_predicate_exprt` sub classes
thomasspriggs Mar 7, 2022
0f6ae1c
Add `binary_predicate_exprt` sub class unit tests
thomasspriggs Mar 22, 2022
5d7c21c
Add invariant on kind used to construct `binary_overflow_exprt`
thomasspriggs Mar 22, 2022
ce025e1
Use `mult_overflow_exprt` in `boolbvt::convert_overflow`
thomasspriggs Mar 22, 2022
defc6d4
Use `shl_overflow_exprt` in `boolbvt::convert_overflow`
thomasspriggs Mar 22, 2022
0d36c43
Use `plus/minus_overflow_exprt` in `boolbvt::convert_overflow`
thomasspriggs Mar 22, 2022
636ffa8
Use `binary_overflow_exprt` in `expr2ct::convert_with_precedence`
thomasspriggs Mar 22, 2022
d4b17bd
Use `binary_overflow_exprt` in `boolbvt::convert_rest`
thomasspriggs Mar 22, 2022
533a902
Use `plus/minus_overflow_exprt` in `smt2_convt`
thomasspriggs Mar 22, 2022
fdc0fc8
Use `mult_overflow_exprt` in `smt2_convt`
thomasspriggs Mar 22, 2022
12a4451
Use `minus_overflow_exprt` in `simplify_overflow_binary`
thomasspriggs Mar 22, 2022
4e3e8b9
Use `mult_overflow_exprt` in `simplify_overflow_binary`
thomasspriggs Mar 22, 2022
24c9da7
Use `plus_overflow_exprt` in `simplify_overflow_binary`
thomasspriggs Mar 22, 2022
7936b57
Use `shl_overflow_exprt` in `simplify_overflow_binary`
thomasspriggs Mar 22, 2022
98c80dc
Use `binary_overflow_exprt` in `simplify_exprt::simplify_node`
thomasspriggs Mar 22, 2022
631aeb4
Add `unary_minus_overflow_exprt`
thomasspriggs Mar 22, 2022
c0f179c
Use `unary_minus_overflow_exprt`
thomasspriggs Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/util/bitvector_expr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,6 +707,10 @@ class binary_overflow_exprt : public binary_predicate_exprt
binary_overflow_exprt(exprt _lhs, const irep_idt &kind, exprt _rhs)
: binary_predicate_exprt(std::move(_lhs), make_id(kind), std::move(_rhs))
{
INVARIANT(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I quite like this.

I favour things being correct by construction, and subsequently, for the invariants to be set as early as possible.

valid_id(id()),
"The kind used to construct binary_overflow_exprt should be in the set "
"of expected valid kinds.");
}

static void check(
Expand Down