Skip to content

Replace the goto_check indirection by direct use of goto_check_c [blocks: #6688] #6716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022

Conversation

tautschnig
Copy link
Collaborator

All existing calls necessarily end up calling goto_check_c.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #6716 (64aeff2) into develop (4daadad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6716   +/-   ##
========================================
  Coverage    76.79%   76.80%           
========================================
  Files         1589     1589           
  Lines       183667   183656   -11     
========================================
- Hits        141056   141053    -3     
+ Misses       42611    42603    -8     
Impacted Files Coverage Δ
.../goto-instrument/accelerate/acceleration_utils.cpp 2.22% <ø> (ø)
src/goto-programs/goto_check.cpp 100.00% <ø> (+18.60%) ⬆️
.../goto-instrument/goto_instrument_parse_options.cpp 69.39% <100.00%> (ø)
src/goto-programs/process_goto_program.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daa7996...64aeff2. Read the comment docs.

All existing calls necessarily end up calling goto_check_c.
@tautschnig tautschnig force-pushed the cleanup/goto_check_c branch from 4b6c700 to 64aeff2 Compare March 9, 2022 13:33
@tautschnig tautschnig changed the title Replace the goto_check indirection by direct use of goto_check_c Replace the goto_check indirection by direct use of goto_check_c [blocks: #6688] Mar 25, 2022
@tautschnig tautschnig merged commit e4d26e0 into diffblue:develop May 10, 2022
@tautschnig tautschnig deleted the cleanup/goto_check_c branch May 10, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants