Skip to content

smt2: convert mathematical_function types and function_application #6709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

kroening
Copy link
Member

@kroening kroening commented Mar 7, 2022

This change enables the SMT-LIB2 backend to convert 1) function symbols with
type mathematical function and 2) applications of such functions given as
function_application expression.

This enables a number of use cases, e.g., encodings of programs into
constrained Horn clause systems.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #6709 (cace2ce) into develop (6594cbb) will decrease coverage by 0.00%.
The diff coverage is 68.51%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6709      +/-   ##
===========================================
- Coverage    77.15%   77.14%   -0.01%     
===========================================
  Files         1582     1582              
  Lines       182628   182674      +46     
===========================================
+ Hits        140900   140929      +29     
- Misses       41728    41745      +17     
Impacted Files Coverage Δ
src/solvers/smt2/smt2_conv.cpp 67.46% <68.51%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc5d5d...cace2ce. Read the comment docs.

This change enables the SMT-LIB2 backend to convert 1) function symbols with
type mathematical function and 2) applications of such functions given as
function_application expression.

This enables a number of use cases, e.g., encodings of programs into
constrained Horn clause systems.
@peterschrammel peterschrammel removed their assignment Mar 8, 2022
@tautschnig tautschnig merged commit fdda7a8 into develop Mar 8, 2022
@tautschnig tautschnig deleted the smt2_mathematical_function branch March 8, 2022 15:07
@tautschnig tautschnig mentioned this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants