Skip to content

Include source location in JSON/XML property output #6696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

Unlike the plain-text variant, neither JSON nor XML included source
locations for each of the properties being reported upon by a
goto-checker.

Fixes: #6651

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Unlike the plain-text variant, neither JSON nor XML included source
locations for each of the properties being reported upon by a
goto-checker.

Fixes: diffblue#6651
@tautschnig tautschnig force-pushed the feature/json-xml-property-info branch from 55b5aa6 to 88c5acc Compare February 24, 2022 17:00
@tautschnig tautschnig marked this pull request as ready for review February 24, 2022 17:09
@tautschnig tautschnig assigned chris-ryder and unassigned tautschnig Feb 24, 2022
Copy link
Contributor

@TGWDB TGWDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a placeholder to ensure this does not get merged immediately due to changes to XML output. Apologies for adding it, I should be able to remove it in a few days.

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #6696 (55b5aa6) into develop (05e1fd6) will increase coverage by 0.02%.
The diff coverage is 96.80%.

❗ Current head 55b5aa6 differs from pull request most recent head 88c5acc. Consider uploading reports for the commit 88c5acc to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6696      +/-   ##
===========================================
+ Coverage    76.89%   76.91%   +0.02%     
===========================================
  Files         1582     1583       +1     
  Lines       183170   183352     +182     
===========================================
+ Hits        140840   141026     +186     
+ Misses       42330    42326       -4     
Impacted Files Coverage Δ
src/goto-instrument/reachability_slicer_class.h 100.00% <ø> (ø)
jbmc/src/jbmc/jbmc_parse_options.cpp 72.46% <50.00%> (ø)
...c/solvers/smt2_incremental/convert_expr_to_smt.cpp 65.35% <92.45%> (+4.02%) ⬆️
src/cbmc/cbmc_parse_options.cpp 77.61% <100.00%> (+0.04%) ⬆️
src/goto-checker/properties.cpp 80.53% <100.00%> (+0.35%) ⬆️
.../goto-instrument/goto_instrument_parse_options.cpp 69.36% <100.00%> (+0.11%) ⬆️
src/goto-instrument/reachability_slicer.cpp 99.34% <100.00%> (+0.07%) ⬆️
src/goto-programs/remove_calls_no_body.cpp 100.00% <100.00%> (ø)
...t/solvers/smt2_incremental/convert_expr_to_smt.cpp 100.00% <100.00%> (ø)
src/goto-programs/xml_expr.cpp 51.21% <0.00%> (-3.05%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fec06a...88c5acc. Read the comment docs.

@kroening kroening removed their assignment Feb 28, 2022
@TGWDB TGWDB self-requested a review March 7, 2022 09:17
@tautschnig tautschnig merged commit de9fa65 into diffblue:develop Mar 7, 2022
@tautschnig tautschnig deleted the feature/json-xml-property-info branch March 7, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include property information in json output
5 participants