Skip to content

Make CBMC and JBMC share solver-related command-line parsing #6680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

tautschnig
Copy link
Collaborator

The actual options are evaluated by (shared) solver_factoryt. Hence,
both tools should permit the same set of command-line options.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The actual options are evaluated by (shared) solver_factoryt. Hence,
both tools should permit the same set of command-line options.
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #6680 (e9680db) into develop (222d266) will increase coverage by 0.01%.
The diff coverage is 93.80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6680      +/-   ##
===========================================
+ Coverage    76.82%   76.83%   +0.01%     
===========================================
  Files         1582     1582              
  Lines       182767   182728      -39     
===========================================
- Hits        140403   140396       -7     
+ Misses       42364    42332      -32     
Impacted Files Coverage Δ
src/goto-checker/solver_factory.h 100.00% <ø> (ø)
src/goto-programs/string_abstraction.h 100.00% <ø> (ø)
unit/util/piped_process.cpp 31.29% <33.33%> (ø)
jbmc/src/jbmc/jbmc_parse_options.cpp 76.02% <50.00%> (+3.56%) ⬆️
src/ansi-c/c_typecheck_expr.cpp 76.45% <50.00%> (ø)
src/cbmc/cbmc_parse_options.cpp 78.72% <50.00%> (+1.16%) ⬆️
src/goto-checker/solver_factory.cpp 76.55% <75.38%> (+0.55%) ⬆️
src/goto-programs/string_abstraction.cpp 92.46% <90.90%> (ø)
...solvers/smt2_incremental/smt_bit_vector_theory.cpp 100.00% <100.00%> (ø)
...rc/solvers/smt2_incremental/smt_solver_process.cpp 68.57% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79c1637...e9680db. Read the comment docs.

Copy link
Contributor

@TGWDB TGWDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup

@tautschnig tautschnig merged commit fb3f391 into diffblue:develop Feb 24, 2022
@tautschnig tautschnig deleted the cleanup/opt_solver branch February 24, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants