Skip to content

Deprecate multi-argument variants of exprt::copy_to_operands #6671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tautschnig
Copy link
Collaborator

add_to_operands or constructors with move semantics are preferable. All
existing uses of the newly deprecated methods have been reworked to use
non-deprecated methods.

Fixes: #2809

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #6671 (8dde888) into develop (1154f13) will increase coverage by 0.17%.
The diff coverage is 87.01%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6671      +/-   ##
===========================================
+ Coverage    76.92%   77.10%   +0.17%     
===========================================
  Files         1583     1582       -1     
  Lines       183314   182609     -705     
===========================================
- Hits        141018   140799     -219     
+ Misses       42296    41810     -486     
Impacted Files Coverage Δ
src/cpp/cpp_typecheck_conversions.cpp 85.14% <0.00%> (+0.10%) ⬆️
src/goto-instrument/dump_c.cpp 80.49% <0.00%> (+0.28%) ⬆️
src/goto-instrument/dump_c_class.h 100.00% <ø> (ø)
src/goto-instrument/goto_program2code.cpp 68.84% <0.00%> (+0.06%) ⬆️
src/goto-programs/builtin_functions.cpp 56.86% <0.00%> (ø)
src/goto-programs/xml_expr.cpp 51.21% <0.00%> (ø)
src/jsil/jsil_convert.cpp 0.00% <0.00%> (ø)
src/util/expr.h 96.96% <ø> (-0.26%) ⬇️
src/util/expr_util.h 100.00% <ø> (ø)
src/util/pointer_predicates.cpp 93.10% <ø> (-0.45%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 352be59...8dde888. Read the comment docs.

@tautschnig tautschnig force-pushed the cleanup/deprecate-copy_to_operands-nary branch from 18a0517 to f353b3f Compare February 15, 2022 14:45
@kroening kroening removed their assignment Feb 16, 2022
@tautschnig tautschnig force-pushed the cleanup/deprecate-copy_to_operands-nary branch from f353b3f to e2e671d Compare February 16, 2022 21:41
add_to_operands or constructors with move semantics are preferable. All
existing uses of the newly deprecated methods have been reworked to use
non-deprecated methods.

Fixes: diffblue#2809
@tautschnig tautschnig force-pushed the cleanup/deprecate-copy_to_operands-nary branch from e2e671d to 8dde888 Compare February 26, 2022 18:12
@tautschnig tautschnig merged commit 08e1655 into diffblue:develop May 10, 2022
@tautschnig tautschnig deleted the cleanup/deprecate-copy_to_operands-nary branch May 10, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the multi-argument variants of exprt::move_to_operands and expr::copy_to_operands
4 participants