-
Notifications
You must be signed in to change notification settings - Fork 273
Run C regression tests using clang and gcc when both are available #6670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run C regression tests using clang and gcc when both are available #6670
Conversation
10c28e9
to
f6600cf
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6670 +/- ##
===========================================
+ Coverage 76.92% 77.13% +0.20%
===========================================
Files 1583 1582 -1
Lines 183314 182625 -689
===========================================
- Hits 141018 140868 -150
+ Misses 42296 41757 -539
Continue to review full report at Codecov.
|
f6600cf
to
bde4f66
Compare
bde4f66
to
1e58f14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like an improvement, so approving as is - but just wondering slightly what the reasoning behind enabling these test profiles only when there is both clang and gcc available? Could the different profiles not just run when based on the availability of the single compiler needed? (e.g. ansi-c-clang
running only if clang
is available, ansi-c-gcc
only if gcc
is available, etc? rather than having a semperate 'else' block for running if only one of those two is available?
…ration The preprocessor variant is only relevant for c_preprocess, and isn't actually set by goto-cc (which does not use c_preprocess). Fixes: diffblue#2370
Our C front-end seeks to conform to whatever interpretation of the C standard the underlying host C compiler has. To avoid incompatibilities as documented in diffblue#2370, run regression tests using both Clang and GCC, if available on a particular system.
1e58f14
to
272fe76
Compare
Yes, I now cannot think of a good reason why I restricted it to both having to be available. I have now changed this as suggested. |
Our C front-end seeks to conform to whatever interpretation of the C
standard the underlying host C compiler has. To avoid incompatibilities
as documented in #2370, run regression tests using both Clang and GCC,
if available on a particular system.