Skip to content

Add remaining SMT bv functions to theory #6669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thomasspriggs
Copy link
Contributor

This PR add remaining SMT bv functions to theory. This should entail a full set of functions being present once the PR is merged.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

const smt_bit_vector_constant_termt a_valid{42, 16}, b_valid{8, 16};
SECTION("Valid operands")
{
const auto concat = smt_bit_vector_theoryt::compare(a_valid, b_valid);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to rename concat here to compare to make the code clearer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #6669 (e59a77c) into develop (b26ad8b) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6669      +/-   ##
===========================================
+ Coverage    76.76%   76.81%   +0.05%     
===========================================
  Files         1582     1582              
  Lines       182360   182767     +407     
===========================================
+ Hits        139992   140396     +404     
- Misses       42368    42371       +3     
Impacted Files Coverage Δ
...solvers/smt2_incremental/smt_bit_vector_theory.cpp 100.00% <100.00%> (ø)
...solvers/smt2_incremental/smt_bit_vector_theory.cpp 100.00% <100.00%> (ø)
src/util/signal_catcher.cpp 84.61% <0.00%> (-11.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c558465...e59a77c. Read the comment docs.

@thomasspriggs thomasspriggs force-pushed the tas/smt_bv_functions_completion branch from 1f65da0 to e59a77c Compare February 15, 2022 12:23
@thomasspriggs thomasspriggs merged commit a3e1411 into diffblue:develop Feb 15, 2022
@thomasspriggs thomasspriggs deleted the tas/smt_bv_functions_completion branch February 15, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants