Skip to content

Add additional subset of bitvector theory bitwise operations #6666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 15, 2022

Conversation

thomasspriggs
Copy link
Contributor

This PR adds an additional subset of bitvector theory bitwise operations n preparation for conversion to these operators from exprts.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #6666 (53c53f3) into develop (30d747b) will increase coverage by 0.03%.
The diff coverage is 93.20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6666      +/-   ##
===========================================
+ Coverage    76.76%   76.79%   +0.03%     
===========================================
  Files         1582     1582              
  Lines       182357   182600     +243     
===========================================
+ Hits        139984   140231     +247     
+ Misses       42373    42369       -4     
Impacted Files Coverage Δ
src/ansi-c/c_typecheck_base.h 100.00% <ø> (ø)
src/solvers/flattening/boolbv.h 62.50% <ø> (ø)
src/solvers/flattening/boolbv_byte_extract.cpp 83.11% <ø> (ø)
src/solvers/flattening/bv_utils.h 85.71% <ø> (ø)
src/util/piped_process.cpp 81.48% <ø> (ø)
src/solvers/flattening/boolbv_add_sub.cpp 48.33% <43.75%> (ø)
src/ansi-c/c_typecheck_expr.cpp 76.59% <83.87%> (ø)
src/solvers/flattening/bv_utils.cpp 79.61% <96.87%> (ø)
src/ansi-c/expr2c.cpp 66.24% <100.00%> (+0.30%) ⬆️
src/goto-checker/single_path_symex_checker.cpp 85.89% <100.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e831f43...53c53f3. Read the comment docs.

Copy link
Contributor

@NlightNFotis NlightNFotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns have been addressed.

Copy link
Contributor

@TGWDB TGWDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, happy to see me questions (in call) are clarified.

@thomasspriggs thomasspriggs merged commit c558465 into diffblue:develop Feb 15, 2022
@thomasspriggs thomasspriggs deleted the tas/smt_bv_functions branch February 15, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants