Skip to content

Add tests for --div-by-zero and --signed-overflow checks for the new SMT backend #6665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

NlightNFotis
Copy link
Contributor

This PR adds two more tests to the regression test-suite of the new SMT
backend, that are exercising the code under two flags adding extra assertions.

The status right now is that --div-by-zero works, whereas --signed-overflow-check
fails with an unimplemented invariant.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@NlightNFotis NlightNFotis self-assigned this Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #6665 (73c3952) into develop (30d747b) will increase coverage by 0.00%.
The diff coverage is 85.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6665   +/-   ##
========================================
  Coverage    76.76%   76.76%           
========================================
  Files         1582     1582           
  Lines       182357   182357           
========================================
+ Hits        139984   139987    +3     
+ Misses       42373    42370    -3     
Impacted Files Coverage Δ
src/ansi-c/c_typecheck_base.h 100.00% <ø> (ø)
src/ansi-c/expr2c.cpp 65.94% <ø> (ø)
src/solvers/flattening/boolbv.h 62.50% <ø> (ø)
src/solvers/flattening/boolbv_byte_extract.cpp 83.11% <ø> (ø)
src/solvers/flattening/bv_utils.h 85.71% <ø> (ø)
src/util/piped_process.cpp 81.48% <ø> (ø)
src/solvers/flattening/boolbv_add_sub.cpp 48.33% <43.75%> (ø)
src/ansi-c/c_typecheck_expr.cpp 76.59% <83.87%> (ø)
src/solvers/flattening/bv_utils.cpp 79.61% <96.87%> (ø)
src/goto-checker/single_path_symex_checker.cpp 85.89% <100.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e831f43...73c3952. Read the comment docs.

@NlightNFotis NlightNFotis merged commit 1fd7a56 into diffblue:develop Feb 14, 2022
@NlightNFotis NlightNFotis deleted the flag_tests_smt_arithop branch February 14, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants