Skip to content

Cleanup build_sizeof_expr #6664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

tautschnig
Copy link
Collaborator

This code is entirely specific to the C front-end. See each of the two commits for more details.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

expr2c is the only user of a function that does entirely
C-frontend-specific work. It constructs a "sizeof" expression in the way
the C frontend expects such an expression to look like.
Make sure we use any peculiar properties of "sizeof" that size_of_expr
will make sure to handle: pointer_offset_size performs size computation
using the runtime size, and not C-frontend specific oddities.
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #6664 (673bd73) into develop (30d747b) will increase coverage by 0.00%.
The diff coverage is 85.94%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6664   +/-   ##
========================================
  Coverage    76.76%   76.76%           
========================================
  Files         1582     1582           
  Lines       182357   182357           
========================================
+ Hits        139984   139988    +4     
+ Misses       42373    42369    -4     
Impacted Files Coverage Δ
src/ansi-c/c_typecheck_base.h 100.00% <ø> (ø)
src/solvers/flattening/boolbv.h 62.50% <ø> (ø)
src/solvers/flattening/boolbv_byte_extract.cpp 83.11% <ø> (ø)
src/solvers/flattening/bv_utils.h 85.71% <ø> (ø)
src/util/piped_process.cpp 81.48% <ø> (ø)
src/util/pointer_offset_size.cpp 92.52% <ø> (+0.29%) ⬆️
src/solvers/flattening/boolbv_add_sub.cpp 48.33% <43.75%> (ø)
src/ansi-c/c_typecheck_expr.cpp 76.59% <83.87%> (ø)
src/ansi-c/expr2c.cpp 66.24% <93.10%> (+0.30%) ⬆️
src/solvers/flattening/bv_utils.cpp 79.61% <96.87%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e831f43...673bd73. Read the comment docs.

@tautschnig tautschnig assigned tautschnig and unassigned kroening and chris-ryder Feb 14, 2022
@tautschnig tautschnig merged commit c1d59c9 into diffblue:develop Feb 14, 2022
@tautschnig tautschnig deleted the cleanup/build_sizeof_expr branch February 14, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants