Skip to content

Annotate flexible array members #6663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

Make sure we can distinguish flexible array members from other arrays,
for example when wanting to distinguish their compile-time from their
runtime size.

This is in preparation of #6661.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #6663 (24eba85) into develop (1154f13) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6663      +/-   ##
===========================================
+ Coverage    76.92%   77.09%   +0.16%     
===========================================
  Files         1583     1582       -1     
  Lines       183314   182650     -664     
===========================================
- Hits        141018   140817     -201     
+ Misses       42296    41833     -463     
Impacted Files Coverage Δ
jbmc/src/janalyzer/janalyzer_parse_options.cpp 48.75% <100.00%> (ø)
jbmc/src/jbmc/jbmc_parse_options.cpp 76.02% <100.00%> (ø)
jbmc/src/jdiff/jdiff_parse_options.cpp 67.74% <100.00%> (-0.35%) ⬇️
src/analyses/goto_check.cpp 81.39% <100.00%> (+17.75%) ⬆️
src/analyses/goto_check_c.cpp 91.60% <100.00%> (-0.01%) ⬇️
src/ansi-c/c_typecheck_type.cpp 77.08% <100.00%> (ø)
.../goto-instrument/goto_instrument_parse_options.cpp 69.39% <100.00%> (+0.03%) ⬆️
src/goto-programs/process_goto_program.cpp 100.00% <100.00%> (ø)
src/util/pointer_offset_size.cpp 92.56% <100.00%> (+0.04%) ⬆️
src/util/simplify_expr.cpp 85.56% <100.00%> (+0.01%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e616881...24eba85. Read the comment docs.

@tautschnig tautschnig force-pushed the feature/annotate-flexible-array branch from c5d255a to 0d22cdf Compare February 14, 2022 13:07
Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. I guess testing will be via another PR, probably #6661 ?

Make sure we can distinguish flexible array members from other arrays,
for example when wanting to distinguish their compile-time from their
runtime size.
@tautschnig tautschnig force-pushed the feature/annotate-flexible-array branch from bb8e608 to 24eba85 Compare February 25, 2022 20:07
@tautschnig tautschnig merged commit 59ff926 into diffblue:develop Feb 26, 2022
@tautschnig tautschnig deleted the feature/annotate-flexible-array branch February 26, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants