Skip to content

C nondet symbol factory: arrays may have zero size #6662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2022

Conversation

tautschnig
Copy link
Collaborator

There is nothing fundamentally wrong in an array having size 0.

Fixes: #5093

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #6662 (f507eae) into develop (52d5788) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6662      +/-   ##
===========================================
- Coverage    76.81%   76.81%   -0.01%     
===========================================
  Files         1582     1582              
  Lines       182764   182776      +12     
===========================================
+ Hits        140399   140405       +6     
- Misses       42365    42371       +6     
Impacted Files Coverage Δ
src/ansi-c/c_typecheck_expr.cpp 76.45% <50.00%> (-0.15%) ⬇️
src/ansi-c/c_nondet_symbol_factory.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8562df3...f507eae. Read the comment docs.

@tautschnig tautschnig force-pushed the bugfixes/5093-gen-nondet branch from d6543fb to 58f96b0 Compare February 14, 2022 14:05
There is nothing fundamentally wrong in an array having size 0. Also, do
not assume that size has an unsigned type.

Fixes: diffblue#5093
@tautschnig tautschnig force-pushed the bugfixes/5093-gen-nondet branch from 58f96b0 to f507eae Compare February 16, 2022 21:43
@tautschnig tautschnig merged commit 352be59 into diffblue:develop Feb 26, 2022
@tautschnig tautschnig deleted the bugfixes/5093-gen-nondet branch February 26, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pointer to struct with flexible array member as parameter to entry point causes invariant violation
3 participants