Add saturating addition/subtraction #6647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
feature/saturating-arithmetic
branch
2 times, most recently
from
95f7c8d to
22ae750
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6647 +/- ##
=========================================
Coverage 76.73% 76.74%
=========================================
Files 1579 1579
Lines 182008 182173 +165
=========================================
+ Hits 139671 139803 +132
- Misses 42337 42370 +33
Continue to review full report at Codecov.
|
tautschnig
force-pushed
the
feature/saturating-arithmetic
branch
from
22ae750 to
98f43f7
Compare
tautschnig
requested review from
chris-ryder,
kroening,
martin-cs and
peterschrammel
as code owners
peterschrammel
approved these changes
Feb 7, 2022
tautschnig
force-pushed
the
feature/saturating-arithmetic
branch
from
98f43f7 to
c6c6938
Compare
tautschnig
force-pushed
the
feature/saturating-arithmetic
branch
2 times, most recently
from
ed29bfa to
518af1c
Compare
chris-ryder
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
Assuming I've followed all the bit operations correctly, I think that looks reasonable to me. As an aside, the phrase "For C code, it takes MMX instructions to have access to this" of course only applies to x86/amd64. ARM of course has it's own instructions and compiler intrinsics for saturated arithmetic.
| @@ -229,6 +229,8 @@ bvt boolbvt::convert_bitvector(const exprt &expr) | |||
| } | |||
| else if(expr.id() == ID_bitreverse) | |||
| return convert_bitreverse(to_bitreverse_expr(expr)); | |||
| else if(expr.id() == ID_saturating_minus || expr.id() == ID_saturating_plus) | |||
| return convert_saturating_add_sub(to_binary_expr(expr)); | |||
There was a problem hiding this comment.
Minor nit pick... there's a mis-match of terminology here - plus vs add, minus vs sub - should we pick one and settle?
tautschnig
force-pushed
the
feature/saturating-arithmetic
branch
4 times, most recently
from
50a4004 to
22defef
Compare
Rust natively supports saturating arithmetic. For C code, it takes MMX instructions to have access to this (which will be implemented in the next commit), and even then it is limited to addition and subtraction. The implementation now is equally restricted to these two arithmetic operations. Fixes: diffblue#5841
With the newly added saturating addition/subtraction it is possible to support MMX instructions performing saturating arithmetic over vectors.
tautschnig
force-pushed
the
feature/saturating-arithmetic
branch
from
22defef to
10ea245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust natively supports saturating arithmetic. For C code, it takes MMX
instructions to have access to this, and even then it is limited to
addition and subtraction. The implementation now is equally restricted
to these two arithmetic operations.